| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
| Cc: | Joachim Wieland <joe(at)mcknight(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Materialized view assertion failure in HEAD |
| Date: | 2013-03-15 15:47:51 |
| Message-ID: | 6476.1363362471@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kevin Grittner <kgrittn(at)ymail(dot)com> writes:
> I failed to touch everything necessary to prevent MVs from having
> OIDs. This patch fixes the reported problem, and doesn't leave any
> gaps as far as I know; but I will do additional review to try to
> catch any other omissions. I figured I should address the reported
> problem now, though.
> Will push later today if there are no objections.
I object --- that's not a fix, that's a crude hack. It should not be
necessary to introduce relkind tests there. Determination of whether
OIDs exist in the target table should happen well upstream, ie in
whatever is constructing the intoClause. Otherwise we'll be fixing
code that examines the intoClause until doomsday.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2013-03-15 15:57:51 | Re: Materialized view assertion failure in HEAD |
| Previous Message | Kevin Grittner | 2013-03-15 15:36:00 | Re: Materialized view assertion failure in HEAD |