Re: [v9.1] sepgsql - userspace access vector cache

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Kohei Kaigai <Kohei(dot)Kaigai(at)emea(dot)nec(dot)com>, Yeb Havinga <yebhavinga(at)gmail(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [v9.1] sepgsql - userspace access vector cache
Date: 2011-08-19 13:59:45
Message-ID: 6464.1313762385@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> writes:
> 2011/8/18 Robert Haas <robertmhaas(at)gmail(dot)com>:
>> Actually, as I look at this more, I think this build system is
>> completely mis-designed. Given that you want to build sepgsql,
>> selinux is not an optional feature. So the stuff in
>> contrib/sepgsql/Makefile that is intended to link against libselinux
>> only if --with-selinux was specified at configure time is nonsense.

What stuff is that?

> So, it seems to me we also need to revise configure script, not only
> Makefile of sepgsql.

This patch seems unnecessary to me. The way it works now appears to be
quite parallel to the way that contrib/xml2 works, and has worked for
years. I don't think that sepgsql should behave differently from that.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-08-19 14:06:55 Re: [v9.1] sepgsql - userspace access vector cache
Previous Message Tom Lane 2011-08-19 13:41:50 Re: "make -j4 world" falls over