Re: Move cursor support for pl/pgsql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Move cursor support for pl/pgsql
Date: 2007-03-02 15:17:14
Message-ID: 6325.1172848634@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> I took a stab at implementing MOVE support for cursors in PL/pgsql,
> because I wanted it for a project. Attached patch *seems* to work. But..
> Given that this is my first venture into touching bison/flex files, I
> may be completely off-target in how it's done.

I disapprove of hard-wiring the fetch count as an integer constant;
there's no good reason not to treat it as an expression. So you should
drop the T_NUMBER thing.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-03-02 15:49:24 Re: Move cursor support for pl/pgsql
Previous Message Tom Lane 2007-03-02 14:59:57 Re: A little COPY speedup