| From: | Florian Pflug <fgp(at)phlo(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Negative Transition Aggregate Functions (WIP) |
| Date: | 2014-04-11 22:18:28 |
| Message-ID: | 607546D7-45C0-464C-94A5-FAFB769D7378@phlo.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Apr11, 2014, at 19:42 , Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Florian Pflug <fgp(at)phlo(dot)org> writes:
>> Yes, the idea had come up at some point during the review discussion. I
>> agree that it's only worthwhile if it works for state type internal - though
>> I think there ought to be a way to allow that. We could for example simply
>> decree that the initfunc's first parameter must be of type internal if it's
>> return type is, and then just pass NULL for that parameter.
>
> I had thought about that, but it doesn't really work since it'd be
> violating the strictness spec of the function.
Only if we insist on passing SQL NULL, not if we passed an non-NULL value
that happens to be (char*)0.
Or we could simply require the initfunc to be non-strict in the case of
state type internal.
best regards,
Florian Pflug
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2014-04-12 03:22:50 | Re: WIP patch (v2) for updatable security barrier views |
| Previous Message | Jan Wieck | 2014-04-11 21:07:29 | Problem with txid_snapshot_in/out() functionality |