Re: unfathomable comment in psqlscan.l

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: unfathomable comment in psqlscan.l
Date: 2010-01-26 19:22:19
Message-ID: 603c8f071001261122i7971cb16kd62e96dbbb4854dd@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 26, 2010 at 2:12 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> While reviewing Pavel's patch for variable quoting in psql, I came
>> upon the following comment in psqlscan.l:
>
>>         /*
>>          * The variable value is just emitted without any
>>          * further examination.  This is consistent with the
>>          * pre-8.0 code behavior, if not with the way that
>>          * variables are handled outside backslash commands.
>>          */
>
>> I cannot figure out for the life of me what this is referring to.
>
> At the other place where :foo is expanded, the value is pushed for
> re-scanning; thus for example ":bar" within the variable value
> might be further expanded as a reference to some other variable.
> Inside backslash commands we don't do that but just take the value
> literally.

Ah, makes sense. Thanks.

...Robert

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Boszormenyi Zoltan 2010-01-26 19:46:02 Re: ECPGset_var
Previous Message Simon Riggs 2010-01-26 19:19:33 Re: Dividing progress/debug information in pg_standby, and stat before copy