| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | marcin mank <marcin(dot)mank(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: bug: fuzzystrmatch levenshtein is wrong |
| Date: | 2009-12-09 02:45:25 |
| Message-ID: | 603c8f070912081845n48a3070fmd2dc0c1d48cb791c@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 8, 2009 at 9:08 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Robert Haas wrote:
>> > patch attached.
>>
>> I cannot get this patch to apply for anything. All 4 hunks fail, both
>> on HEAD and on the the pre-8.4-pgindent version of fuzzystrmatch.c.
>> Either I'm doing something wrong here, or there's something wrong with
>> this patch file.
>
> The author converted tabs to spaces --- there is not a single tab in the
> diff file.
Ah. I knew there had to be a reason.
I'm attaching my version of this patch. Barring objections, I am
going to apply this to HEAD and backpatch to 8.4, where this feature
(and the associated bug) were introduced.
...Robert
| Attachment | Content-Type | Size |
|---|---|---|
| levenshtein.diff | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2009-12-09 02:47:10 | Re: YAML Was: CommitFest status/management |
| Previous Message | Bruce Momjian | 2009-12-09 02:39:12 | Re: Installing PL/pgSQL by default |