Re: operator exclusion constraints

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: operator exclusion constraints
Date: 2009-11-20 03:58:38
Message-ID: 603c8f070911191958q19bd45a8gd194f789d4cd2350@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 18, 2009 at 9:21 AM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> All,
>
> FWIW, I'm doing a redesign of a client's production web application
> right now.  I was able, by combining OEC and the Period type from
> pgfoundry, to make a set of constraints for declaratively asserting in a
> sports database:
>
> That the same player couldn't belong to two different teams at the same
> time;
> That the same player couldn't belong to the same team in two different
> positions with overlapping time periods.
>
> This worked as spec'd, and would be extremely useful for this real-world
> app if it was ready to use in production now.
>
> However, I do have an issue with the SQLSTATE returned from the OEC
> violation.  Currently it returns constraint violation, which, from the
> perspective of an application developer, is not useful.  OECs are, in
> application terms, materially identical to UNIQUE constraints and serve
> the same purpose.  As such, I'd far rather see OECs return unique key
> violation instead, as any existing application error-trapping code would
> handle the violation more intelligently if it did.

I guess I'm going to have to vote -1 on this proposal. I code see
inventing a pgsql-specific SQLSTATE value for exclusion constraints,
since they will be a pgsql-specific extension, but reusing the unique
key violation value seems misleading. I admit it may help in a
limited number of cases, but IMHO it's not worth the confusion.

That's just my $0.02, though.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2009-11-20 04:36:59 Re: operator exclusion constraints
Previous Message Robert Haas 2009-11-20 03:55:39 Re: operator exclusion constraints