Re: [PATCH] Largeobject access controls

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Largeobject access controls
Date: 2009-10-15 14:53:20
Message-ID: 603c8f070910150753j301966bicc3b9c8b50c72f6a@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2009/10/15 Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>:
> KaiGai Kohei wrote:
>> I have to focus on my patches with highest priority in CommitFest,
>> but it may be possible to help reviewing the proposed patches in
>> the off-fest season. It is illegal/undesirable for the process?
>
> No, that's absolutely fine. During commitfests patch review is needed
> the most, but please do help whenever you have the time.

I agree. I would also mention that reviewing a patch can often be
done in a few hours, and there are certainly periods of downtime
during a CommitFest when your own patches won't need attention. Of
course, a major patch like Hot Standby needs a lot more reviewing, but
that's an exceptional case, and there's really no need for you to bite
off something that ambitious. Just reviewing 1 or 2 small patches per
CommitFest would be much appreciated, if it's something you can
manage.

Reviewing patches at other times is very helpful too. Many times
patch authors complain about not getting feedback between CommitFests,
so anything you can pick up and give feedback on helps move the
project forward (and also decreases the amount that has to get done
during the next CommitFest).

Thanks,

...Robert

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-10-15 15:06:23 Re: EXPLAIN BUFFERS
Previous Message Tom Lane 2009-10-15 14:53:15 Re: Trigger with WHEN clause (WIP)