Re: Filtering dictionaries support and unaccent dictionary

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Filtering dictionaries support and unaccent dictionary
Date: 2009-08-07 03:46:57
Message-ID: 603c8f070908062046g3211617t4974ebe43deeb94d@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2009/8/6 Teodor Sigaev <teodor(at)sigaev(dot)ru>:
>> Isn't that function leaking "res" pointer?  Also, I'm curious why you're
>
> fixed
>
>> allocating 2*sizeof(TSLexeme) in unaccent_lexize ...
>
> That's is a dictionary's interface part: lexize returns an array of TSLexeme
> and last structure should have lexeme field NULL.
>
>
> filter_dictionary file is not changed, it's attached only for consistency.

I am not sure whether this has been formally reviewed by anyone yet;
do we think it's "Ready for Committer"?

Thanks,

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-08-07 03:49:52 Re: [PATCH] pgbench: new feature allowing to launch shell commands
Previous Message Fujii Masao 2009-08-07 03:43:18 Re: pg_ctl stop -m fast after -m smart