Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Jeremy Kerr <jk(at)ozlabs(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros
Date: 2009-07-15 02:59:05
Message-ID: 603c8f070907141959y5b662a4akbdec04145c0b04bd@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 14, 2009 at 8:42 PM, Jeremy Kerr<jk(at)ozlabs(dot)org> wrote:
> Hi, Alvaro,
>
>> Does this work in compilers other than GCC?  I think we use some
>> kludges to protect against them ... see pg_list.h for the canonical
>> example.
>
> As I understand it, we're not using static inlines in pg_list.h to
> prevent multiple objects from exporting the same symbols if the
> functions don't end up as 'static inline' (ie, because the compiler
> doesn't support that).
>
> In this case, we're only compiling the inlines into a single object, so
> even if the compiler doesn't support inlines, we'll just end up with
> out-of-line function calls, which should work too.

Perhaps we should use macros.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message higepon 2009-07-15 03:20:47 Re: pg_dump Add dumping of comments on index columns
Previous Message Alvaro Herrera 2009-07-15 02:24:33 Re: navigation menu for documents