Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator

From: Euler Taveira <euler(at)timbira(dot)com(dot)br>
To: Roma Sokolov <sokolov(dot)r(dot)v(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Женя Зайцев <zevlg(at)yandex(dot)ru>
Subject: Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator
Date: 2016-02-27 00:46:21
Message-ID: 56D0F1DD.8000808@timbira.com.br
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 26-02-2016 17:51, Roma Sokolov wrote:
> Fixed the patch to be more descriptive and to avoid repeating same
> computation over and over again. See v2 of the patch attached.
>
Oh, much better.

> Why do you think that? Should I remove them or maybe send as separate
> patch?
>
Because it is not a common practice to test catalog dependency on
separate tests (AFAICS initial catalogs are tested with oidjoins.sql).
Also, your test case is too huge for such a small use case. If you can
reduce it to a small set of commands using some of the oidjoins.sql
queries, I think it could be sufficient.

--
Euler Taveira Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2016-02-27 00:49:50 Re: pgsql: Respect TEMP_CONFIG when running contrib regression tests.
Previous Message Simon Riggs 2016-02-27 00:33:52 Re: Relation cache invalidation on replica