| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: a fast bloat measurement tool (was Re: Measuring relation free space) |
| Date: | 2015-04-24 14:35:22 |
| Message-ID: | 553A54AA.2020401@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/24/15 14:58, Amit Kapila wrote:
> On Fri, Apr 24, 2015 at 8:46 AM, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com
> <mailto:ams(at)2ndquadrant(dot)com>> wrote:
> >
> > At 2015-04-24 08:35:40 +0530, amit(dot)kapila16(at)gmail(dot)com
> <mailto:amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > > Just stick a PG_RETURN_NULL() at the end?
> > >
> > > That should also work.
> >
> > OK, updated patch attached with just that one change.
> >
>
> Patch looks good to me, will mark it as Ready for Committer if Tomas
> or anyone else doesn't have more to add in terms of review.
FWIW, I'm OK with the patch as is. Your reviews were spot on.
regards
--
Tomas Vondra http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2015-04-24 16:07:30 | Re: PL/pgSQL, RAISE and error context |
| Previous Message | Kouhei Kaigai | 2015-04-24 14:23:29 | Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API) |