Re: PL/pgSQL, RAISE and error context

From: Marko Tiikkaja <marko(at)joh(dot)to>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Merlin Moncure <mmoncure(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PL/pgSQL, RAISE and error context
Date: 2015-04-23 07:53:58
Message-ID: 5538A516.5020206@joh.to
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/2/15 9:37 AM, Pavel Stehule wrote:
>> estate->err_text = stmt->elog_level == ERROR ? estate->err_text :
>> raise_skip_msg ;
>
> Can we do this simple change? It will produce a stackinfo for exceptions
> and it will not to make mad developers by lot of useless content.

I'm not sure everyone agrees with this to be honest, myself included.

I think the best way to do this would be to have an option for RAISE to
suppress the context *regardless of nesting depth*, but show the full
context by default for ERRORs. For NOTICEs and WARNINGs I don't care
much what the default will be; perhaps just full backwards compatibility
could work there.

.m

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-04-23 07:55:17 Re: INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0
Previous Message Andres Freund 2015-04-23 07:45:14 Re: Code paths where LWLock should be released on failure