Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)
Date: 2015-02-26 01:06:04
Message-ID: 54EE717C.4040901@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/24/15 1:23 AM, Michael Paquier wrote:
>
>
> On Mon, Feb 23, 2015 at 9:31 PM, Robert Haas <robertmhaas(at)gmail(dot)com
> <mailto:robertmhaas(at)gmail(dot)com>> wrote:
>
>
> > On Feb 22, 2015, at 5:41 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com <mailto:michael(dot)paquier(at)gmail(dot)com>> wrote:
> > This is up to the maintainer of each extension to manage their code
> > tree. However I can imagine that some people would be grateful if we
> > allow them to not need sql/ and expected/ containing only one single
> > .gitignore file ignoring everything with "*", making the code tree of
> > their extensions cleaner.
>
> I don't see this as an improvement. What's wrong with a .gitignore
> file ignoring everything?
>
>
> That's mainly a matter of code maintenance style (and I am on the side
> that a minimum number of folders in a git tree makes things easier to
> follow), and IMO it is strange to not have some flexibility. Btw, the
> reason why this patch exists is this thread of last December:
> http://www.postgresql.org/message-id/flat/20141212134508(dot)GT1768(at)alvh(dot)no-ip(dot)org#20141212134508(dot)GT1768@alvh.no-ip.org

What's an example of this? I ask because what I'd like is to break the
cluster management portion of pg_regress out on it's own to make it easy
to get that functionality while using a different test framework (like
pgTap).
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2015-02-26 01:24:18 Re: Partitioning WIP patch
Previous Message Alvaro Herrera 2015-02-26 01:04:39 Re: a fast bloat measurement tool (was Re: Measuring relation free space)