| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | amit(dot)kapila16(at)gmail(dot)com, michael(dot)paquier(at)gmail(dot)com, jaime(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org, tv(at)fuzzy(dot)cz |
| Subject: | Re: TABLESAMPLE patch |
| Date: | 2015-01-28 10:33:55 |
| Message-ID: | 54C8BB13.3020901@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 28/01/15 08:23, Kyotaro HORIGUCHI wrote:
> Hi, I took a look on this and found nice.
>
> By the way, the parameter for REPEATABLE seems allowing to be a
> expression in ParseTableSample but the grammer rejects it.
>
It wasn't my intention to support it, but you are correct, the code is
generic enough that we can support it.
> The following change seems enough.
>
Seems about right, thanks.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-01-28 11:47:19 | Re: Misaligned BufferDescriptors causing major performance problems on AMD |
| Previous Message | Petr Jelinek | 2015-01-28 10:19:34 | Re: TABLESAMPLE patch |