| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Using 128-bit integers for sum, avg and statistics aggregates |
| Date: | 2015-01-27 08:21:48 |
| Message-ID: | 54C74A9C.2090509@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/27/2015 09:05 AM, Andres Freund wrote:
> On 2015-01-27 08:21:57 +0100, Andreas Karlsson wrote:
>> On 01/23/2015 02:58 AM, Petr Jelinek wrote:
>>> On 23/01/15 00:40, Andreas Karlsson wrote:
>>>> - Renamed some things from int12 to int128, there are still some places
>>>> with int16 which I am not sure what to do with.
>>>
>>> I'd vote for renaming them to int128 too, there is enough C functions
>>> that user int16 for 16bit integer that this is going to be confusing
>>> otherwise.
>>
>> Do you also think the SQL functions should be named numeric_int128_sum,
>> numeric_int128_avg, etc?
>
> I'm pretty sure we already decided upthread that the SQL interface is
> going to keep usint int4/8 and by extension int16.
Excellent, then I will leave my latest patch as-is and let the reviewer
say what he thinks.
--
Andreas Karlsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-01-27 08:27:53 | Re: Safe memory allocation functions |
| Previous Message | Andres Freund | 2015-01-27 08:17:46 | Re: Hot Standby WAL reply uses heavyweight session locks, but doesn't have enough infrastructure set up |