Re: [HACKERS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: bouda(at)edookit(dot)com, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON
Date: 2015-01-13 15:56:48
Message-ID: 54B54040.5040804@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 11/30/14 11:45 AM, Tom Lane wrote:
> The "API break" isn't a big issue imo. The net effect would be that eg
> hstore 9.3.6 wouldn't work against a 9.3.5 server. We do that sort of
> thing *all the time* --- at least twice in the past year, according to
> a quick scan of the commit logs. If you were changing or removing a
> function that third-party code might depend on, it'd be problematic,
> but an addition has no such risk.

This sort of things is actually a bit of an annoyance, because it means
that for minor-version upgrades, you need to stop the server before
unpacking the new version, otherwise the old running server will try to
load the new hstore module and fail with a symbol lookup. This can
increase the downtime significantly.

Yes, we've done this before, and people have gotten bitten by it before.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Eisentraut 2015-01-13 15:59:44 Re: BUG #12106: pg_dump does not resolve circular dependency
Previous Message koizumistr 2015-01-13 13:22:01 BUG #12534: missing 'with' at X055

Browse pgsql-hackers by date

  From Date Subject
Next Message Timmer, Marius 2015-01-13 16:04:49 Re: [PATCH] explain sortorder
Previous Message Tom Lane 2015-01-13 15:19:40 Re: OOM on EXPLAIN with lots of nodes