Re: Commitfest problems

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Joe Conway <mail(at)joeconway(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Commitfest problems
Date: 2014-12-12 21:22:10
Message-ID: 548B5C82.6010708@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/12/14, 1:44 PM, Joshua D. Drake wrote:
> 1. We don't need a full-time engineer to manage a commitfest. We need a manager or PM.

I don't think that's actually true. The major points on this thread are that 1) we don't have enough capacity for doing reviews and 2) the CFM has no authority to enforce anything.

I see no way that #2 can be addressed by a mere manager/PM. If three *very* senior community members (David, Josh and Robert) couldn't get this done there's no way a PM could. (Well, I suppose of Tom was standing behind them with a flaming sword it might work...)

Even so, this still wouldn't address the real problem, which is lack of review capacity.

FWIW, I faced the same problem at Enova: good, solid reviews were very important for maintaining the quality of the data and database code, yet were a constant source of pain and friction. And that was with people being paid to do them, as well as a very extensive set of unit tests.

In other words, this isn't an easy problem to solve.

One thing that I think would help is modifying the CF app to allow for multiple reviewers. IIRC I reviewed 4 or 5 patches but I didn't mark myself as reviewer of any of them because I don't feel I have enough knowledge to fulfill that role.
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2014-12-12 21:28:33 Re: On partitioning
Previous Message Robert Haas 2014-12-12 21:13:09 Re: PATCH: hashjoin - gracefully increasing NTUP_PER_BUCKET instead of batching