| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Alex Shulgin <ash(at)commandprompt(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add shutdown_at_recovery_target option to recovery.conf |
| Date: | 2014-12-08 00:59:54 |
| Message-ID: | 5484F80A.8030008@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05/12/14 16:49, Robert Haas wrote:
> On Thu, Dec 4, 2014 at 8:45 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> Here is patch which renames action_at_recovery_target to
>>> recovery_target_action everywhere.
>> Thanks, Looks good to me.
>>
>> A couple of things that would be good to document as well in
>> recovery-config.sgml:
>> - the fact that pause_at_recovery_target is deprecated.
>
> Why not just remove it altogether? I don't think the
> backward-compatibility break is enough to get excited about, or to
> justify the annoyance of carrying an extra parameter that does (part
> of) the same thing.
>
Ok this patch does that, along with the rename to recovery_target_action
and addition to the recovery.conf.sample.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| recovery_target_action-v2.patch | text/x-diff | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-12-08 01:01:47 | Re: WIP: multivariate statistics / proof of concept |
| Previous Message | Michael Paquier | 2014-12-08 00:57:44 | Re: detect custom-format dumps in psql and emit a useful error |