Re: tracking commit timestamps

From: Petr Jelinek <petr(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Anssi Kääriäinen <anssi(dot)kaariainen(at)thl(dot)fi>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Subject: Re: tracking commit timestamps
Date: 2014-11-25 15:33:15
Message-ID: 5474A13B.9050007@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On 25/11/14 16:30, Alvaro Herrera wrote:
> Petr Jelinek wrote:
>> On 25/11/14 16:23, Alvaro Herrera wrote:
>>> Robert Haas wrote:
>
>>>> Maybe 0 should get translated to a NULL return, instead of a bogus timestamp.
>>>
>>> That's one idea --- surely no transaction is going to commit at 00:00:00
>>> on 2000-01-01 anymore. Yet this is somewhat discomforting.
>>
>> I solved it for xids that are out of range by returning -infinity and then
>> changing that to NULL in sql interface, but no idea how to do that for
>> aborted transactions.
>
> I guess the idea is that we just read the value from the slru and if it
> exactly matches allballs we do the same -infinity return and translation
> to NULL. (Do we really love this -infinity idea? If it's just an
> internal API we can use a boolean instead.)
>

As in returning boolean instead of void as "found"? That works for me
(for the C interface).

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2014-11-25 15:42:10 Re: test_shm_mq failing on mips*
Previous Message Alvaro Herrera 2014-11-25 15:30:33 Re: tracking commit timestamps

Browse pgsql-www by date

  From Date Subject
Next Message Simon Riggs 2014-11-25 16:16:00 Re: tracking commit timestamps
Previous Message Alvaro Herrera 2014-11-25 15:30:33 Re: tracking commit timestamps