| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Asif Naeem <anaeem(dot)it(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add shutdown_at_recovery_target option to recovery.conf |
| Date: | 2014-11-19 16:22:45 |
| Message-ID: | 546CC3D5.8090504@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19/11/14 16:47, Simon Riggs wrote:
> On 19 November 2014 13:13, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>
>> Also, for the Shutdown itself, why are we not using
>> kill(PostmasterPid, SIGINT)?
>
> Done
>
> Other plan is to throw a FATAL message.
>
>> That gives a clean, fast shutdown rather than what looks like a crash.
>
> I've also changed the location of where we do
> RECOVERY_TARGET_ACTION_SHUTDOWN, so its in the same place as where we
> pause.
>
Another problem with how you did these two changes is that if you just
pause when you send kill then during clean shutdown the recovery will be
resumed and will finish renaming the recovery.conf to recovery.done,
bumping timeline etc, and we don't want that since that prevents
resuming recovery in the future.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-11-19 16:23:47 | Re: Functions used in index definitions shouldn't be changed |
| Previous Message | Tom Lane | 2014-11-19 16:13:07 | Re: proposal: plpgsql - Assert statement |