| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Asif Naeem <anaeem(dot)it(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add shutdown_at_recovery_target option to recovery.conf |
| Date: | 2014-11-19 16:11:16 |
| Message-ID: | 546CC124.5010501@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19/11/14 17:04, Simon Riggs wrote:
> On 19 November 2014 15:57, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> On 2014-11-19 15:47:05 +0000, Simon Riggs wrote:
>>>> Also, for the Shutdown itself, why are we not using
>>>> kill(PostmasterPid, SIGINT)?
>>>
>>> Done
>>
>> I don't think that's ok. The postmaster is the one that should be in
>> control, not some subprocess.
>>
>> I fail to see the win in simplicity over using exit (like we already do
>> for the normal end of recovery!) is. The issue with the log line seems
>> perfectly easily to avoid by just checking the exit code in
>> postmaster.c.
>
> We need to be able to tell the difference between a crashed Startup
> process and this usage.
>
> As long as we can tell, I don't mind how we do it.
>
> Suggestions please.
>
Different exit code?
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-11-19 16:12:22 | Re: Add shutdown_at_recovery_target option to recovery.conf |
| Previous Message | Simon Riggs | 2014-11-19 16:04:49 | Re: Add shutdown_at_recovery_target option to recovery.conf |