Re: Build broken on mips

On 11/11/2014 01:08 AM, Heikki Linnakangas wrote:
> On 11/08/2014 12:25 AM, Rémi Zara wrote:
>> Hi,
>>
>> The build is broken on mips on the HEAD branch.
>> Here is a patch to fix that (builds and make check is OK on NetBSD/cobalt 7.99.1, GCC 4.8.4):
>
> Thanks, committed!

To verify this, I tried compiling PostgreSQL on a emulated qemu mips64el
Debian system, and this still doesn't work:

> gcc -O0 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -I../../../../src/include -D_GNU_SOURCE -c -o xlog.o xlog.c
> xlog.c: In function ‘XLogInsertRecord’:
> xlog.c:1022:3: error: expected ‘(’ before ‘)’ token
> xlog.c: In function ‘ReserveXLogInsertLocation’:

Looks like I missed the additional colon you had in your patch. Oops.
I'll go fix that.

- Heikki