Re: TAP test breakage on MacOS X

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TAP test breakage on MacOS X
Date: 2014-10-26 14:39:28
Message-ID: 544D07A0.7090105@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/9/14 3:38 PM, Robert Haas wrote:
> The problem is that running initdb --not-a-valid-option leaves $? set
> to 256, as seems entirely unsurprising. After running the anonymous
> block passed to it, Test::Builder::subtest calls Test::Build::finalize
> which calls Test::Build::_ending, which sets $real_exit_code to $? -
> i.e. 256. That function later throws up if $real_exit_code isn't 0,
> hence the failure.
>
> Off-hand, I'm not quite sure why this works for anyone.

Thank you for this analysis. The problem is that the version of
Test::Simple that ships with Perl 5.12 is broken in this particular way.
I have committed a fix to skip the tests in that case.

You might want to review whether this is really the Perl installation
that you want to use. It looks like it is coming from MacPorts, and
they have stopped updating their perl package.

I have run the PostgreSQL build against all Perl major versions between
5.8 and 5.20, and there have been no more unaddressed version-related
issues.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2014-10-26 15:02:50 Re: TAP test breakage on MacOS X
Previous Message Marti Raudsepp 2014-10-26 12:56:02 Re: [PATCH] Simplify EXISTS subqueries containing LIMIT