| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Verbose output of pg_dump not show schema name |
| Date: | 2014-08-26 08:53:54 |
| Message-ID: | 53FC4B22.4070805@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/26/2014 10:10 AM, Michael Paquier wrote:
> On Tue, Aug 26, 2014 at 3:48 AM, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
>> AFAICS, the namespace can never be NULL in any of these. There is a
>> "selectSourceSchema(fout, tbinfo->dobj.namespace->dobj.name)" call before or
>> after printing the message, so if tbinfo->dobj.namespace is NULL, you'll
>> crash anyway. Please double-check, and remove the dead code if you agree.
> Ah right, this field is used in many places. Even for
> pg_backup_archiver.c, the portion of code processing data always has
> the namespace set. I am sure that Fabrizio would have done that
> quickly, but as I was on this thread I simplified the patch as
Ok thanks, committed.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-08-26 08:57:05 | Re: postgresql latency & bgwriter not doing its job |
| Previous Message | Fabien COELHO | 2014-08-26 08:49:31 | Re: postgresql latency & bgwriter not doing its job |