From: | Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Christoph Berg <cb(at)df7cb(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: ALTER SYSTEM RESET? |
Date: | 2014-06-27 06:49:25 |
Message-ID: | 53AD13F5.1020701@dalibo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 06/27/2014 06:22 AM, Amit Kapila wrote:
> On Thu, Jun 26, 2014 at 8:17 PM, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com
> <mailto:vik(dot)fearing(at)dalibo(dot)com>> wrote:
>> On 06/26/2014 05:07 AM, Amit Kapila wrote:
>> > I think it will make sense if we support RESET ALL as well similar
>> > to Alter Database .. RESET ALL syntax. Do you see any reason
>> > why we shouldn't support RESET ALL syntax for Alter System?
>>
>> Yes, that makes sense. I've added that in the attached version 2 of the
>> patch.
>
> I think the idea used in patch to implement RESET ALL is sane. In passing
> by, I noticed that modified lines in .sgml have crossed 80 char
> boundary which
> is generally preferred to be maintained..
>
> Refer below modification.
>
> ! values to the <filename>postgresql.auto.conf</filename> file.
> Setting the parameter to
> ! <literal>DEFAULT</literal>, or using the <command>RESET</command>
> variant, removes the configuration entry from
I did that on purpose so that it's easy for a reviewer/committer to see
what changed.
This third patch reformats the documentation in the way I expected it to
be committed.
--
Vik
Attachment | Content-Type | Size |
---|---|---|
alter_system_reset.v3.patch | text/x-diff | 9.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2014-06-27 06:54:42 | Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop] |
Previous Message | Pavel Stehule | 2014-06-27 06:33:38 | Re: review: Built-in binning functions |