From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | rm_desc signature |
Date: | 2014-06-13 11:37:33 |
Message-ID: | 539AE27D.3010003@vmware.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
As part of the WAL-format changing patch I've been working on, I changed
the signature of the rm_desc function from:
void (*rm_desc) (StringInfo buf, uint8 xl_info, char *rec);
void (*rm_desc) (StringInfo buf, XLogRecord *record);
The WAL-format patch needed that because it added more functions/macros
for working with XLogRecords, also used by rm_desc routines, but it
seems like a sensible change anyway. IMHO it was always a bit strange
that rm_desc was passed the info field and record payload separately.
So I propose to do that change as a separate commit. Per attached. This
has no functional changes, it's just refactoring.
Any objections?
- Heikki
Attachment | Content-Type | Size |
---|---|---|
rm_desc-signature-change-1.patch | text/x-diff | 23.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-06-13 11:39:58 | Re: rm_desc signature |
Previous Message | Fujii Masao | 2014-06-13 11:27:26 | Re: pg_resetxlog to clear backup start/end locations. |