Re: [COMMITTERS] pgsql: Replace duplicate_oids with Perl implementation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Geoghegan <pg(at)heroku(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Replace duplicate_oids with Perl implementation
Date: 2013-11-10 23:12:20
Message-ID: 5386.1384125140@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> It might be a bit more portable if we replaced the shebang lines on perl
> scripts with
> #!/bin/env perl

Perhaps, if we're worried about people keeping perl somewhere other
than /usr/bin. However, the most likely reason for having a
/usr/local/bin/perl or whatever is that it's a newer and shinier one
than what's in /usr/bin. Since we're only interested in bog-standard
perl, there's no real reason for us to want to pick up the local one.

FWIW, there was a big discussion at Red Hat a few years ago about whether
to run around and do that to all perl/python scripts, and the outcome of
the discussion was that using env was deprecated, not encouraged. I don't
remember the reasoning in detail, but I think the core idea was that if a
distro knows they ship perl in /usr/bin, then inserting env into the
equation doesn't do anything but add cycles and failure modes. I'm not
sure that that argument applies too well to our scenario, but it's out
there. The particular application to this case might be: what makes
you so sure env is in /bin?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2013-11-11 13:40:14 pgsql: Don't abort pg_basebackup when receiving empty WAL block
Previous Message Andres Freund 2013-11-10 22:51:06 Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-11-10 23:16:16 Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist
Previous Message Andres Freund 2013-11-10 22:11:59 Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist