Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD

From: Matteo Beccati <php(at)beccati(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Date: 2014-05-26 10:03:19
Message-ID: 53831167.2060909@beccati.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tom,

On 25/05/2014 21:10, Tom Lane wrote:
> Anyhow, doing it like that seems like it ought to be a pretty
> straightforward refactoring of your patch. I could pursue that,
> or you can.

I'm attaching v2 of the patch. Here's a list of changes from v1:

* Restored --with-ossp-uuid. Configure tries ossp support first, then
falls back to Linux and BSD variants
* md5.o and sha1.o are linked only when not using the ossp library
* fixed a bug in the v1mc generation carried over from uuid-freebsd:
only the mac part is randomized now
* updated regression tests, which are now passing on ubuntu w/ and w/o
ossp and netbsd.

This was the best I could achieve in the limited timeframe I had
available. I believe it could be a good starting point for your final
refactoring.

Cheers
--
Matteo Beccati

Development & Consulting - http://www.beccati.com/

Attachment Content-Type Size
uuid_v2.patch text/plain 52.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Albe Laurenz 2014-05-26 10:33:12 Re: IMPORT FOREIGN SCHEMA statement
Previous Message Amit Langote 2014-05-26 09:50:40 Allowing line-continuation in pgbench custom scripts