| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: Logical replication woes |
| Date: | 2014-05-16 08:35:48 |
| Message-ID: | 5375CDE4.5050200@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05/15/2014 11:58 PM, Andres Freund wrote:
> On 2014-05-15 22:30:53 +0300, Heikki Linnakangas wrote:
>>> Attached patch fixes things, but I want to add some regression tests
>>> before commit.
>>
>> Looks good to me.
>
> Attached are two patches. One for the unitialized dbId/tsId issue; one
> for the decoding bug. The former should be backpatched.
Thanks, committed.
> Should you wonder about the slight reordering of the assignments in
> RecordTransactionCommitPrepared() - I've made it more similar to RecordTransactionCommit()
> to make it easier to see they are equivalent.
Makes sense.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2014-05-16 08:46:55 | Re: SKIP LOCKED DATA (work in progress) |
| Previous Message | Andres Freund | 2014-05-16 07:59:19 | Re: 9.0 PDF build broken |