| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Marko Kreen <markokr(at)gmail(dot)com>, Jan Wieck <jan(at)wi3ck(dot)info> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Problem with txid_snapshot_in/out() functionality |
| Date: | 2014-05-15 15:33:19 |
| Message-ID: | 5374DE3F.4000600@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/14/2014 11:55 AM, Marko Kreen wrote:
> On Sun, Apr 13, 2014 at 05:46:20PM -0400, Jan Wieck wrote:
>> On 04/13/14 14:22, Jan Wieck wrote:
>>> On 04/13/14 08:27, Marko Kreen wrote:
>>>> I think you need to do SET_VARSIZE also here. Alternative is to
>>>> move SET_VARSIZE after sort_snapshot().
>>>>
>>>> And it seems the drop-double-txid logic should be added also to
>>>> txid_snapshot_recv(). It seems weird to have it behave differently
>>> >from txid_snapshot_in().
>>>>
>>>
>>> Thanks,
>>>
>>> yes on both issues. Will create another patch.
>>
>> New patch attached.
>>
>> New github commit is https://github.com/wieck/postgres/commit/b8fd0d2eb78791e5171e34aecd233fd06218890d
>
> Looks OK to me.
Ok, committed.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-05-15 15:48:01 | Re: Unportability of setvbuf() |
| Previous Message | Tom Lane | 2014-05-15 14:49:38 | Unportability of setvbuf() |