From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Hadi Moshayedi <hadi(at)moshayedi(dot)net> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: A question about code in DefineRelation() |
Date: | 2014-05-12 06:45:32 |
Message-ID: | 53706E0C.7040802@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Hadi,
Sorry for the delay.
(2014/04/25 22:39), Hadi Moshayedi wrote:
> On second thought I noticed that that makes CREATE FOREIGN TABLE include
> an OID column in newly-created foreign tables wrongly, when the
> default_with_oids parameter is set to on. Please find attached a patch.
> The fix makes sense to me, since in ALTER TABLE SET WITH OIDS we check
> that the relation is a table and not a foreign table:
>
> 3160 case AT_AddOids:/* SET WITH OIDS */
> 3161 ATSimplePermissions(rel, ATT_TABLE);
>
> So, I think we should be consistent between DefineRelation() and alter
> table.
Thank you for the review.
I added this to 2014-06 and marked it as "Ready for Committer".
Best regards,
Etsuro Fujita
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2014-05-12 06:52:38 | Re: inherit support for foreign tables |
Previous Message | Michael Paquier | 2014-05-12 06:25:01 | Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?) |