| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Create function prototype as part of PG_FUNCTION_INFO_V1 |
| Date: | 2014-04-14 19:28:25 |
| Message-ID: | 534C36D9.1000803@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/4/14, 10:07 AM, Andres Freund wrote:
> If
> somebody previously tried to do the correct thing and attached
> PGDLLEXPORT to their own *function* prototoype, it would cause problems
> now.
What is the difference (on affected platforms) between
Datum funcname(PG_FUNCTION_ARGS);
and writing (effectively)
PGDLLEXPORT Datum funcname(PG_FUNCTION_ARGS);
Datum funcname(PG_FUNCTION_ARGS);
or for that matter
Datum funcname(PG_FUNCTION_ARGS);
PGDLLEXPORT Datum funcname(PG_FUNCTION_ARGS);
If there isn't a difference, then my patch is fine. Otherwise, it might
be good to document the issues for extension authors.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2014-04-14 19:31:47 | Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements |
| Previous Message | Heikki Linnakangas | 2014-04-14 18:48:18 | Re: Race condition between PREPARE TRANSACTION and COMMIT PREPARED (was Re: Problem with txid_snapshot_in/out() functionality) |