| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti |
| Date: | 2014-04-04 15:26:20 |
| Message-ID: | 533ECF1C.7040709@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 04/04/2014 06:06 PM, Robert Haas wrote:
> On Fri, Apr 4, 2014 at 10:32 AM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>> In checkpoint, move the check for in-progress xacts out of critical section.
>>
>> GetVirtualXIDsDelayingChkpt calls palloc, which isn't safe in a critical
>> section. I thought I covered this case with the exemption for the
>> checkpointer, but CreateCheckPoint is also called from the startup process.
>
> This commit un-broke "make check", which you might have wanted to run
> before committing, but "make -C src/test/isolation check" is still
> broken.
Yeah.. Fixed now.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-04-04 15:33:14 | pgsql: Fix some compiler warnings that clang emits with -pedantic. |
| Previous Message | Heikki Linnakangas | 2014-04-04 15:26:04 | pgsql: Move multixid allocation out of critical section. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-04-04 15:33:56 | Re: jsonb is also breaking the rule against nameless unions |
| Previous Message | Robert Haas | 2014-04-04 15:18:10 | Re: Fwd: Proposal: variant of regclass |