From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Useless "Replica Identity: NOTHING" noise from psql \d |
Date: | 2014-03-27 15:45:52 |
Message-ID: | 533447B0.90300@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 03/27/2014 11:34 AM, Christoph Berg wrote:
> Re: Andrew Dunstan 2014-03-27 <53344465(dot)6010401(at)dunslane(dot)net>
>> On 03/27/2014 11:27 AM, Tom Lane wrote:
>>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>>> I guess we'd better add a make-contrib-check step to the buildfarm. I
>>>> was just prepping a release, so I'll delay that while I add this.
>>> BTW, won't that obsolete the need for the separate check-pg_upgrade
>>> step?
>> Yes, possibly.
>>
>> It helps if people bring to my attention changes in the build and test
>> infrastructure, sometimes I miss developments, as I did here.
> Why not "make check-world"? That should include everything, and
> doesn't need updating the scripts when something new gets included in
> PostgreSQL itself. The pg_upgrade test is included.
>
For several reasons. It's not simply a matter of running that command.
You also have to bundle up the various log files. Also, if all we do is
"check-world" and it fails that fact gives us relatively little
information, whereas if it passes "make check" but fails "make -C
contrib check" we'll have more information. So I'm not terribly excited
about combining steps too much.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2014-03-27 15:56:02 | Re: Useless "Replica Identity: NOTHING" noise from psql \d |
Previous Message | Christoph Berg | 2014-03-27 15:34:02 | Re: Useless "Replica Identity: NOTHING" noise from psql \d |