Re: pg_dump without explicit table locking

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Joe Conway <mail(at)joeconway(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <jim(at)nasby(dot)net>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Jürgen Strobel <juergen+pg(at)strobel(dot)info>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump without explicit table locking
Date: 2014-03-18 00:48:41
Message-ID: 532797E9.6080907@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/18/2014 07:20 AM, Joe Conway wrote:
> On 03/17/2014 04:15 PM, Tom Lane wrote:
>> Jim Nasby <jim(at)nasby(dot)net> writes:
>>> On 3/17/14, 8:47 AM, Tom Lane wrote:
>>>> (Note that this is only one of assorted O(N^2) behaviors in
>>>> older versions of pg_dump; we've gradually stamped them out
>>>> over time.)
>
>>> On that note, it's recommended that when you are taking a
>>> backup to restore into a newer version of Postgres you create
>>> the dump using the NEWER version of pg_dump, not the old one.
>
>> Right. IIRC, the OP said he *did* use a recent pg_dump ... but
>> this particular issue got fixed server-side, so the new pg_dump
>> didn't help against an 8.1 server :-(
>
> Exactly. I backported the patch from 9.3 to 8.4 and saw a
> schema-only dump time go from <give-up-and-kill-it-after-5-days> to
> 1 hour. This was for a database with about 500k tables.

I wonder if doing large batches of

LOCK TABLE table1, table2, table3, ...

would help, instead of doing individual statements?

- --
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTJ5fpAAoJELBXNkqjr+S2XMkH/jhhyET40uuc+zkwpJzW6j7x
o6x2VsaME0PpFUZE5iRL0FDEbHovwznZsQFOPFaCOqZ9vCL1P0JWl6Wf1JNZPJSr
NkwT08PsiOFmtXvnGh5109z3Of6ADGyEKCWHp7msxokzj1whJqzcIbyjAajUq21K
wgnYksH6TUVuutDg6r6PPaNTbmIvcxHwRs58hYi8JUIXdzIyYSlLdPezAo0VjwGw
8GHUQYy4r/hkSDWA4ViZ6ZjDIIgzT46nrTdxkGNPZn4Oz8k6nASnFFZhLfanytQI
YQhqlmIa/jievlZX5Q38snIPE+KYEq3buYK/OmbKuDCfHotC9nNNDCHdop7Qs4c=
=zQoC
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2014-03-18 00:49:32 Wiki Page Draft for upcoming release
Previous Message Andres Freund 2014-03-18 00:24:26 Re: Patch: show relation and tuple infos of a lock to acquire