| From: | Marko Tiikkaja <marko(at)joh(dot)to> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Florian Pflug <fgp(at)phlo(dot)org>, Marti Raudsepp <marti(at)juffo(dot)org> |
| Subject: | Re: plpgsql.warn_shadow |
| Date: | 2014-03-14 11:02:32 |
| Message-ID: | 5322E1C8.4080100@joh.to |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/14/14 10:56 AM, Simon Riggs wrote:
> The patch looks fine, apart from some non-guideline code formatting issues.
I'm not sure what you're referring to. I thought it looked fine.
> Having looked at gcc and clang, I have a proposal for naming/API
>
> We just have two variables
>
> plpgsql.compile_warnings = 'list' default = 'none'
> plpgsql.compile_errors = 'list' default = 'none'
>
> Only possible values in 9.4 are 'shadow', 'all', 'none'
I'm fine with this. I'm starting to think that runtime warnings are a
bad idea anyway.
Regards,
Marko Tiikkaja
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2014-03-14 11:03:56 | Re: Failure while inserting parent tuple to B-tree is not fun |
| Previous Message | Heikki Linnakangas | 2014-03-14 10:42:21 | Re: Archive recovery won't be completed on some situation. |