Re: Replication slots and footguns

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Replication slots and footguns
Date: 2014-03-12 20:34:47
Message-ID: 5320C4E7.1020803@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/12/2014 12:34 PM, Robert Haas wrote:
>>> Urgh. That error message looks susceptible to improvement. How about:
>>> >>
>>> >> replication slot "%s" cannot be dropped because it is currently in use
>> >
>> > I think that'd require duplicating some code between acquire and drop,
>> > but how about "replication slot "%s" is in use by another backend"?
> Sold.

Wait ... before you go further ... I object to dropping the word
"active" from the error message. The column is called "active", and
that's where a DBA should look; that word needs to stay in the error
message.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2014-03-12 20:34:52 Re: jsonb and nested hstore
Previous Message Josh Berkus 2014-03-12 20:33:14 Re: Replication slots and footguns