The case against multixact GUCs

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: The case against multixact GUCs
Date: 2014-03-11 19:14:13
Message-ID: 531F6085.7070909@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hackers,

In the 9.3.3 updates, we added three new GUCs to control multixact
freezing. This was an unprecented move in my memory -- I can't recall
ever adding a GUC to a minor release which wasn't backwards
compatibility for a security fix. This was a mistake.

What makes these GUCs worse is that nobody knows how to set them; nobody
on this list and nobody in the field. Heck, I doubt 1 in 1000 of our
users (or 1 in 10 people on this list) know what a multixact *is*.

Further, there's no clear justification why these cannot be set to be
the same as our other freeze ages (which our users also don't
understand), or a constant calculated portion of them, or just a
constant. Since nobody anticipated someone adding a GUC in a minor
release, there was no discussion of this topic that I can find; the new
GUCs were added as a "side effect" of fixing the multixact vacuum issue.
Certainly I would have raised a red flag if the discussion of the new
GUCs hadn't been buried deep inside really long emails.

Adding new GUCs which nobody has any idea how to set, or can even
explain to new users, is not a service to our users. These should be
removed.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Murtuza Mukadam 2014-03-11 19:37:02 git-review: linking commits to review discussion in git
Previous Message Tom Lane 2014-03-11 18:33:02 Re: [PATCH] Store Extension Options