| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Payal Singh <payal(at)omniti(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode |
| Date: | 2014-03-04 22:44:52 |
| Message-ID: | 53165764.6020004@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/03/2014 06:48 AM, Michael Paquier wrote:
> On Mon, Mar 3, 2014 at 1:13 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>>> That difference actually made the file_fdw regression results plain
>>>> wrong,
>>>> in my view, in that they expected a quoted empty string to be turned to
>>>> null
>>>> even when the null string was something else.
>>>>
>>>> I've adjusted this and the docs and propose to apply the attached patch
>>>> in
>>>> the next day or two unless there are any objections.
>>> Unless I'm overlooking something, output from "SELECT * FROM text_csv;"
>>> in 'output/file_fdw.source' still needs updating?
> While reading this patch, I found a small typo in copy2.[sql|out] =>
> s/violiaton/violation/g
I have picked this up and committed the patch. Thanks to all.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-03-04 22:46:12 | Re: ALTER TABLE lock strength reduction patch is unsafe Reply-To: |
| Previous Message | Andres Freund | 2014-03-04 22:43:55 | Re: ALTER TABLE lock strength reduction patch is unsafe |