Re: narwhal and PGDLLIMPORT

From: Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: narwhal and PGDLLIMPORT
Date: 2014-02-11 20:07:25
Message-ID: 52FA82FD.7010804@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/02/2014 18:15, Tom Lane wrote:
> Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com> writes:
>> On 09/02/2014 14:10, Andrew Dunstan wrote:
>>> On 02/09/2014 01:12 AM, Marco Atzeri wrote:
>>>> we should have get rid of dlltool on cygwin.
>>>> At least it is not used on my build
>
>>> The send in a patch. The patch you sent in previously did not totally
>>> remove it IIRC.
>
>> attached patch versus latest git.
>
> I've committed this with some fixes. However, I omitted the hunks that
> change the names of generated shared libraries (to add SO_MAJOR_VERSION).
> I think that requires some policy discussion around whether we want to
> do it or not, and in any case it's unrelated to the issues being discussed
> in this thread. If you still want that, please submit it as a separate
> patch in a new thread, with some discussion as to why it's a good idea.
>
> regards, tom lane
>

Noted.

On cygwin the shared libraries are using the SO_MAJOR_VERSION
by long time.

cd /usr/bin

$ ls cyggcc*dll
cyggcc_s-1.dll cyggccpp-1.dll

$ ls cygfo*dll
cygfontconfig-1.dll cygform-10.dll cygform-8.dll cygformw-10.dll
cygfontenc-1.dll cygform7.dll cygform-9.dll

In this way we allow coexistence of several release, similar to

/usr/lib/libpq.so.5
on unix.

Regards
Marco

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-02-11 20:43:08 Unhappy with error handling in psql's handleCopyOut()
Previous Message Claudio Freire 2014-02-11 19:51:36 Re: [PERFORM] encouraging index-only scans