Re: narwhal and PGDLLIMPORT

From: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: narwhal and PGDLLIMPORT
Date: 2014-02-10 13:42:57
Message-ID: 52F8D761.4050309@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(2014/02/09 8:06), Andrew Dunstan wrote:
>
> On 02/08/2014 05:34 PM, Tom Lane wrote:
>> Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> writes:
>>> Though I'm not a MINGW expert at all, I know dllwrap is a deprecated
>>> tool and dlltool is almost a deprecated tool. Cygwin port is removing
>>> the use of dllwrap and dlltool now. Isn't it better for MINGW port to
>>> follow it?
>> Only way to make that happen is to prepare and test a patch ...
>
> Yeah. Incidentally, we didn't quite get rid of dlltool for Cygwin. We
> did get rid of dllwrap. But I agree this is worth trying for Mingw.

I tried MINGW port with the attached change and successfully built
src and contrib and all pararell regression tests were OK.

regards,
Hiroshi Inoue

Attachment Content-Type Size
makefiles.patch text/x-patch 2.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-02-10 13:46:25 Memory ordering issue in LWLockRelease, WakeupWaiters, WALInsertSlotRelease
Previous Message Heikki Linnakangas 2014-02-10 13:30:02 Re: Wait free LW_SHARED acquisition - v0.2