| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Typo in a comment? |
| Date: | 2014-02-07 08:26:21 |
| Message-ID: | 52F498AD.7070808@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02/07/2014 08:15 AM, Amit Langote wrote:
> In src/backend/storage/freespace/freespace.c,
>
> *
> * MaxFSMRequestSize depends on the architecture and BLCKSZ, but assuming
> * default 8k BLCKSZ, and that MaxFSMRequestSize is 24 bytes, the categories
> * look like this
> *
>
> Is "24 bytes" a typo considering that
>
> #define MaxFSMRequestSize MaxHeapTupleSize
>
> ?
Yeah. I think it's supposed to say "SizeOfPageHeaderData is 24 bytes",
which would make for a MaxFSMRequestSize of 8164 bytes, as in the
example. It'd probably be more clear to say directly "MaxFSMRequestSize
is 8164 bytes", though. I'll go fix it that way, thanks for the report!
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Albe Laurenz | 2014-02-07 09:12:10 | Re: client encoding that psql command sets |
| Previous Message | Albe Laurenz | 2014-02-07 07:41:26 | Re: PostgreSQL Failback without rebuild |