Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
Cc: Payal Singh <payal(at)omniti(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode
Date: 2014-01-28 15:12:25
Message-ID: 52E7C8D9.1050207@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 01/28/2014 05:55 AM, Ian Lawrence Barwick wrote:
>
> Hi Payal
>
> Many thanks for the review, and my apologies for not getting back to
> you earlier.
>
> Updated version of the patch attached with suggested corrections.

On a very quick glance, I see that you have still not made adjustments
to contrib/file_fdw to accommodate this new option. I don't see why this
COPY option should be different in that respect.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2014-01-28 15:16:24 Re: [PATCH] Implement json_array_elements_text
Previous Message Merlin Moncure 2014-01-28 15:02:23 Re: jsonb and nested hstore