| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio |
| Date: | 2014-01-19 23:36:51 |
| Message-ID: | 52DC6193.5000308@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/17/2014 07:41 PM, Magnus Hagander wrote:
> Regardless of where the other thread goes, this seems like something we
> should fix. Thus - applied, with minor changes to the comment, thanks.
Thanks.
> My understanding is that this change alone doesn't actually help us very
> much, so I haven't backpatched it anywhere. Let me know if that
> understanding was incorrect, and it would actually help as a backpatch.
I don't think there's any point backpatching it - as you say, by its
self it doesn't help tons. There's little or no evidence that anyone's
doing standalone Visual Studio based builds at the moment, and if they
are they'll have already had to define WIN32 themselves so they won't
notice.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Chinner | 2014-01-19 23:51:41 | Re: [Lsf-pc] Linux kernel impact on PostgreSQL performance |
| Previous Message | Andreas Karlsson | 2014-01-19 23:17:04 | Re: GiST support for inet datatypes |