Re: [PATCH] Relocation of tablespaces in pg_basebackup

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Steeve Lennmark <steevel(at)handeldsbanken(dot)se>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Relocation of tablespaces in pg_basebackup
Date: 2014-01-09 18:16:02
Message-ID: 52CEE762.7080509@proxel.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/09/2014 06:58 PM, Steeve Lennmark wrote:
> This patch adds the ability to relocate tablespaces by adding the
> command line argument --tablespace (-T) which takes a required argument
> in the format "oid:tablespacedir". After all tablespaces are fetched
> this code updates the symlink to point to the new tablespace location.
>
> I would have loved to be able to pass tablespacename:tablespacedir
> though, but sadly I wasn't able to figure out how to retrieve that
> information without creating another connection to the database.

This feature would be a nice addition to pg_basebackup, and I agree with
that it would be preferable to use names of oids if possible.

> This feature might be missing because of some other limitation I fail
> to see, if so let me know. Please be gentle, this is my first patch ;-)

It seems like you have attached the wrong patch. The only attachment I
see is 0001-SQL-assertions-prototype.patch.

Best regards,
Andreas

--
Andreas Karlsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Steeve Lennmark 2014-01-09 18:17:16 Re: [PATCH] Relocation of tablespaces in pg_basebackup
Previous Message Josh Berkus 2014-01-09 18:06:24 Re: Standalone synchronous master