Re: [PATCH] Negative Transition Aggregate Functions (WIP)

From: Hannu Krosing <hannu(at)2ndQuadrant(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>, Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu>, Josh Berkus <josh(at)agliodbs(dot)com>
Subject: Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Date: 2013-12-16 08:36:28
Message-ID: 52AEBB8C.4090607@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/16/2013 08:39 AM, David Rowley wrote:
> On Mon, Dec 16, 2013 at 6:00 AM, Ants Aasma <ants(dot)aasma(at)eesti(dot)ee
> <mailto:ants(dot)aasma(at)eesti(dot)ee>> wrote:
>
> On Dec 15, 2013 6:44 PM, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us
> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
> > David Rowley <dgrowleyml(at)gmail(dot)com
> <mailto:dgrowleyml(at)gmail(dot)com>> writes:
> > > I've attached an updated patch which includes some documentation.
> > > I've also added support for negfunc in CREATE AGGREGATE.
> Hopefully that's
> > > an ok name for the option, but if anyone has any better ideas
> please let
> > > them be known.
> >
> > I'd be a bit inclined to build the terminology around "reverse"
> instead of
> > "negative" --- the latter seems a bit too arithmetic-centric.
> But that's
> > just MHO.
>
> To contribute to the bike shedding, inverse is often used in
> similar contexts.
>
> I guess it's not really bike shedding, most of the work I hope is
> done, so I might as well try to get the docs polished up and we'd need
> a consensus on what we're going to call them before I can get that done.
>
> I like both of these better than negative transition function and I
> agree negative implies arithmetic rather than opposite.
> Out of these 2 I do think inverse fits better than reverse, so I guess
> that would make it "inverse aggregate transition function".
> Would that make the CREATE AGGREGATE option be INVFUNC ?
>
> Any other ideas or +1's for any of the existing ones?
+1, inverse good :)
>
> Regards
>
> David Rowley
>
> --
> Ants Aasma
>
>

--
Hannu Krosing
PostgreSQL Consultant
Performance, Scalability and High Availability
2ndQuadrant Nordic OÜ

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2013-12-16 08:39:43 Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Previous Message David Fetter 2013-12-16 07:58:32 Re: [PATCH] Negative Transition Aggregate Functions (WIP)