| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Atri Sharma <atri(dot)jiit(at)gmail(dot)com> |
| Cc: | Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: WITHIN GROUP patch |
| Date: | 2013-12-09 14:29:07 |
| Message-ID: | 52A5D3B3.4040705@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/21/13, 5:04 AM, Atri Sharma wrote:
> Please find attached the latest patch for WITHIN GROUP. This patch is
> after fixing the merge conflicts.
I would like to see more explanations and examples in the documentation.
You introduce this feature with "Ordered set functions compute a single
result from an ordered set of input values." But string_agg, for
example, does that as well, so it's not clear how this is different.
Between ordered aggregates, window functions, and this new feature, it
can get pretty confusing. Also, the "hypothetical" part should perhaps
be explained in more detail. The tutorial part of the documentation
contains a nice introduction to window function. I suggest you add
something like that as well.
In func.sgml, please list the functions in alphabetical order.
Also, don't write "should" when you mean "must".
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2013-12-09 14:49:11 | Re: Backup throttling |
| Previous Message | Andres Freund | 2013-12-09 14:25:25 | Re: BUG #8673: Could not open file "pg_multixact/members/xxxx" on slave during hot_standby |