Re: Skip hole in log_newpage

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Skip hole in log_newpage
Date: 2013-12-03 11:57:04
Message-ID: 529DC710.1080803@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/03/2013 01:37 PM, Andres Freund wrote:
> I haven't looked thoroughly through all callsites, but shouldn't the
> vacuumlazy callsite use std = true?

Well, it's logging an empty page, ie. a page full of zeros. I'm not sure
if you'd consider that a "standard" page. Like the backup-block code in
xlog.c, log_newpage actually makes a full page image without the hole if
pd_lower == 0, even if you pass std = 'true', so the end result is the same.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-12-03 12:03:28 Re: Skip hole in log_newpage
Previous Message Andres Freund 2013-12-03 11:37:22 Re: Skip hole in log_newpage