| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Handling GIN incomplete splits |
| Date: | 2013-11-21 12:44:29 |
| Message-ID: | 528E002D.4050303@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.11.2013 15:27, Michael Paquier wrote:
> Here are some comments about the 4th patch.
> 1) Compiles without warnings, passes make check.
> 2) s/ginFinshSplit/ginFinishSplit
> 3) Server crashes when trying to create a gin index index creation (see
> example of previous email with pg_trgm).
Thanks, fixed!
Here's a new version. To ease the review, I split the remaining patch
again into two, where the first patch is just yet more refactoring.
I also fixed some bugs in WAL logging and replay that I bumped into
while testing.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-More-GIN-refactoring.patch | text/x-diff | 33.8 KB |
| 0002-Get-rid-of-the-post-recovery-cleanup-step-of-GIN-pag.patch | text/x-diff | 60.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2013-11-21 12:58:41 | Re: -d option for pg_isready is broken |
| Previous Message | Dilip kumar | 2013-11-21 11:59:05 | Re: Logging WAL when updating hintbit |